filter_aws: add more IMDS categories #1530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
commiterate
force-pushed
the
add_more_imds_categories
branch
from
09766d6 to
e65b240
Compare
Signed-off-by: commiterate <[email protected]>
commiterate
force-pushed
the
add_more_imds_categories
branch
from
e65b240 to
ba4e7b7
Compare
lockewritesdocs
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Thanks for your contribution @commiterate! I suggested some editorial changes from a technical writing perspective.
| | domain | The domain for AWS resources in the region; for example, "amazonaws.com". | false | | ||
| | region | The [region](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#concepts-regions); for example, "us-east-1". | false | | ||
| | az | The [availability zone](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#concepts-availability-zones); for example, "us-east-1a". | true | | ||
| | az\_id | The [availability zone ID](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#az-ids); for example, "use1-az1". | false | |
There was a problem hiding this comment.
Suggested change
| | az\_id | The [availability zone ID](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#az-ids); for example, "use1-az1". | false | | |
| | az\_id | The [availability zone ID](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#az-ids), such as `"use1-az1"`. | false | |
| | partition | The [partition](https://docs.aws.amazon.com/whitepapers/latest/aws-fault-isolation-boundaries/partitions.html); for example, "aws". | false | | ||
| | domain | The domain for AWS resources in the region; for example, "amazonaws.com". | false | | ||
| | region | The [region](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#concepts-regions); for example, "us-east-1". | false | | ||
| | az | The [availability zone](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#concepts-availability-zones); for example, "us-east-1a". | true | |
There was a problem hiding this comment.
Suggested change
| | az | The [availability zone](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#concepts-availability-zones); for example, "us-east-1a". | true | | |
| | az | The [availability zone](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#concepts-availability-zones), such as `"us-east-1a"`. | true | |
| | az | The [availability zone](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html); for example, "us-east-1a". | true | | ||
| | partition | The [partition](https://docs.aws.amazon.com/whitepapers/latest/aws-fault-isolation-boundaries/partitions.html); for example, "aws". | false | | ||
| | domain | The domain for AWS resources in the region; for example, "amazonaws.com". | false | | ||
| | region | The [region](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#concepts-regions); for example, "us-east-1". | false | |
There was a problem hiding this comment.
Suggested change
| | region | The [region](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#concepts-regions); for example, "us-east-1". | false | | |
| | region | The [region](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html#concepts-regions), such as `"us-east-1"`. | false | |
| @@ -9,11 +9,20 @@ The plugin supports the following configuration parameters: | |||
| | Key | Description | Default | | |||
| | :--- | :--- | :--- | | |||
| | imds\_version | Specify which version of the instance metadata service to use. Valid values are 'v1' or 'v2'. | v2 | | |||
| | az | The [availability zone](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html); for example, "us-east-1a". | true | | |||
| | partition | The [partition](https://docs.aws.amazon.com/whitepapers/latest/aws-fault-isolation-boundaries/partitions.html); for example, "aws". | false | | |||
| | domain | The domain for AWS resources in the region; for example, "amazonaws.com". | false | | |||
There was a problem hiding this comment.
Suggested change
| | domain | The domain for AWS resources in the region; for example, "amazonaws.com". | false | | |
| | domain | The domain for AWS resources in the region, such as `"amazonaws.com"`. | false | |
| @@ -9,11 +9,20 @@ The plugin supports the following configuration parameters: | |||
| | Key | Description | Default | | |||
| | :--- | :--- | :--- | | |||
| | imds\_version | Specify which version of the instance metadata service to use. Valid values are 'v1' or 'v2'. | v2 | | |||
| | az | The [availability zone](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html); for example, "us-east-1a". | true | | |||
| | partition | The [partition](https://docs.aws.amazon.com/whitepapers/latest/aws-fault-isolation-boundaries/partitions.html); for example, "aws". | false | | |||
There was a problem hiding this comment.
Suggested change
| | partition | The [partition](https://docs.aws.amazon.com/whitepapers/latest/aws-fault-isolation-boundaries/partitions.html); for example, "aws". | false | | |
| | partition | The [partition](https://docs.aws.amazon.com/whitepapers/latest/aws-fault-isolation-boundaries/partitions.html), such as `"aws"`. | false | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more IMDS categories.
Relates to fluent/fluent-bit#9640.
Requires fluent/fluent-bit#9727 to be merged.