Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the %L option to the time_format description to make it easier to find #1497

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jakobjoachim
Copy link

No description provided.

@jakobjoachim jakobjoachim requested review from a team as code owners November 1, 2024 14:01
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @jakobjoachim! I added some suggested changes to incorporate for style.

pipeline/parsers/configuring-parser.md Outdated Show resolved Hide resolved
@lockewritesdocs
Copy link
Contributor

@jakobjoachim, can you please sign the DCO?

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

@lecaros lecaros added waiting-for-user Waiting for user/contributors feedback or requested changes dco DCO failing labels Nov 7, 2024
Jakob Joachim and others added 2 commits November 8, 2024 10:27
@jakobjoachim
Copy link
Author

should be done now @lockewritesdocs

@lockewritesdocs lockewritesdocs self-requested a review November 19, 2024 14:34
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakobjoachim! I pushed a minor change to update the formatting of a field from bold to code style. Approved 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco DCO failing waiting-for-user Waiting for user/contributors feedback or requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants