Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add ecs filter e2e test #101

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feature: Add ecs filter e2e test #101

wants to merge 3 commits into from

Conversation

celalettin1286
Copy link
Collaborator

This PR is still draft.
Completed parts:

  • TF scripts creates ECS cluster, supporting resources and deploys fluent-bit service with ecs filter configured with dummy plugin and cluster name from ECS metadata.
  • Since ECS requires OCI image, PR introduces Dockerfile uses fluent-bit master image as base and add fluent-bit.conf.

Next steps:

  • GH Action definitions for building OCI image.
  • Terraform init-plan-apply steps.
  • Bats scripts or GH actions step to check cloudwatch log to validate fluent-bit service.
  • Move terraform scripts to terraform directory.

v2.1.0 test results(manually):
[0] dummy.data: [[1681202733.591231634, {}], {"this is"=>"dummy data", "cluster"=>"fluent-bit-ci"}]

Copy link
Collaborator

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to push an image to ECR to use this or can we just use one built in ghcr.io by the workflow?

@@ -0,0 +1,2 @@
FROM ghcr.io/fluent/fluent-bit/master:x86_64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work for integration tests off master I think.
We need to be able to trigger them on a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants