Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoders: assorted improvements #8

Merged
merged 36 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
5034b0b
build: moved generated headers to build directory
leonardo-albertovich Dec 13, 2024
73eafb5
maintenance: removed erroneously checked in files
leonardo-albertovich Dec 13, 2024
eae8e69
maintenance: added gitignore to prevent acciental build check-ins
leonardo-albertovich Dec 13, 2024
a9db0f5
maintenance: removed erroneously checked in files
leonardo-albertovich Dec 13, 2024
47a9094
build: added cmake asan related files
leonardo-albertovich Dec 13, 2024
1afe736
decoder: encoder: initial commit of various encoders and decoders
leonardo-albertovich Dec 13, 2024
062d1c8
encoder: text: fixed warnings
leonardo-albertovich Dec 13, 2024
1b3eb3e
profile: added guard for implicit behavior
leonardo-albertovich Dec 13, 2024
f6d5d8c
encoder: added related utility helper code and hearders
leonardo-albertovich Dec 13, 2024
890339f
maintenance: added gitignore clause to ignore vscodes context
leonardo-albertovich Dec 13, 2024
a26a09a
build: attempted to fix the missing cprofiles generated header issue
leonardo-albertovich Dec 16, 2024
af73f6b
build: attempted to cause git to update the pinned submodule commit
leonardo-albertovich Dec 16, 2024
ab000e0
build: attempted update the submodule reference again
leonardo-albertovich Dec 16, 2024
c92c91b
build: attempted to fix the build path and branch checkout issues
leonardo-albertovich Dec 16, 2024
3274b8d
build: attempted to fix error I introduced
leonardo-albertovich Dec 16, 2024
aad321c
build: attempted to fix error I introduced
leonardo-albertovich Dec 16, 2024
158dba0
build: attempted to fix more build and test issues
leonardo-albertovich Dec 16, 2024
08a3385
build: attempted to fix centos issue I worsened before
leonardo-albertovich Dec 16, 2024
2601684
build: attempted to fix centos issue I worsened before
leonardo-albertovich Dec 16, 2024
1a2e6af
build: attempted to fix centos issue I worsened before
leonardo-albertovich Dec 16, 2024
f0722b3
build: attempted to fix centos issue I worsened before
leonardo-albertovich Dec 16, 2024
fd2ba53
build: attempted to fix centos issue I worsened before
leonardo-albertovich Dec 16, 2024
c73b5d5
build: attempted to fix security issue
leonardo-albertovich Dec 16, 2024
2152e87
encoder: text: fixed compatibility issue
leonardo-albertovich Dec 16, 2024
e153956
tests: fixed compatibility issue
leonardo-albertovich Dec 16, 2024
dfa81b9
encoder: text: fixed warning
leonardo-albertovich Dec 17, 2024
f6058fd
test: transcoder: added msgpack, text and opentelemetry tests
leonardo-albertovich Dec 17, 2024
cf5c3f0
build: added msgpack, text and opentelemetry tests
leonardo-albertovich Dec 17, 2024
04b85a7
test: decoder: removed deprecated file
leonardo-albertovich Dec 17, 2024
5d17354
test: profile: fixed warning
leonardo-albertovich Dec 17, 2024
dcf114a
decoder: opentelemetry: fixed typo
leonardo-albertovich Dec 17, 2024
8a64932
ci: attempted to fix test case generation issue
leonardo-albertovich Dec 17, 2024
9b06297
test: profile: fixed warning
leonardo-albertovich Dec 17, 2024
9c0b748
decoder: msgpack: addressed previously missed leaks
leonardo-albertovich Dec 17, 2024
d7c0105
encoder: opentelemetry: addressed previously missed leaks
leonardo-albertovich Dec 17, 2024
ff86da6
encoder: text: addressed previously missed uninitialized variable access
leonardo-albertovich Dec 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 28 additions & 11 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,32 @@ jobs:
yum install -y cmake3
shell: bash

- name: Clone repo with submodules (1.8.3 version of Git)
- name: Clone repo without submodules (1.8.3 version of Git)
run: |
git clone --recursive https://github.com/fluent/cprofiles.git
git clone https://github.com/fluent/cprofiles.git
shell: bash

- name: Check out the branch (1.8.3 version of Git)
env:
BRANCH_NAME: ${{ github.head_ref }}
run: |
git checkout "$BRANCH_NAME"
shell: bash
working-directory: cprofiles

- name: Fetch the appropriate sub modules
run: |
git submodule init
git submodule update
shell: bash
working-directory: cprofiles

- name: Run compilation
run: |
cmake3 -DCPROF_DEV=on .
cmake3 -DCPROF_DEV=on ../
make
shell: bash
working-directory: cprofiles
working-directory: cprofiles/build

build-unix-arm64:
name: Build sources on arm64 for ${{ matrix.os }} - ${{ matrix.compiler }}
Expand Down Expand Up @@ -87,9 +102,10 @@ jobs:
file \
make
export CC=${{ env.compiler }}
cmake -DCTR_TESTS=On .
make all
CTEST_OUTPUT_ON_FAILURE=1 make test
cd build
cmake -DCPROF_TESTS=On ../
cmake --build .
CTEST_OUTPUT_ON_FAILURE=1 ctest
env:
CC: ${{ matrix.compiler }}

Expand All @@ -111,10 +127,11 @@ jobs:
- name: Build on ${{ matrix.os }} with ${{ matrix.compiler }}
run: |
echo "CC = $CC, CXX = $CXX"
cmake -DCTR_TESTS=On .
make all
CTEST_OUTPUT_ON_FAILURE=1 make test
cmake -DCPROF_TESTS=On ../
cmake --build .
CTEST_OUTPUT_ON_FAILURE=1 ctest
shell: bash
working-directory: build
env:
CC: ${{ matrix.compiler }}

Expand Down Expand Up @@ -142,5 +159,5 @@ jobs:
with:
preset: ${{ matrix.preset }}
# dependencies_debian: ''
cmakeflags: '-DCTR_TESTS=On -DCMT_DEV=on .'
cmakeflags: '-DCPROF_TESTS=On -DCPROF_DEV=on .'
build_command: make all
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
*~
.vscode/*
build/*
1 change: 1 addition & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
[submodule "lib/fluent-otel-proto"]
path = lib/fluent-otel-proto
url = https://github.com/fluent/fluent-otel-proto

8 changes: 5 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -138,14 +138,16 @@ endif()
# Configure header files
configure_file(
"${PROJECT_SOURCE_DIR}/include/cprofiles/cprof_info.h.in"
"${PROJECT_SOURCE_DIR}/include/cprofiles/cprof_info.h"
"${PROJECT_BINARY_DIR}/include/cprofiles/cprof_info.h"
)

configure_file(
"${PROJECT_SOURCE_DIR}/include/cprofiles/cprof_version.h.in"
"${PROJECT_SOURCE_DIR}/include/cprofiles/cprof_version.h"
"${PROJECT_BINARY_DIR}/include/cprofiles/cprof_version.h"
)

include_directories("${PROJECT_BINARY_DIR}/include/")

# Installation Directories
# ========================
if(${CMAKE_SYSTEM_NAME} MATCHES "Windows")
Expand Down Expand Up @@ -215,7 +217,7 @@ endif()
# fluent-otel-proto
if (NOT CPROF_HAVE_FLUENT_OTEL_PROTO)
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/${CPROF_PATH_LIB_FLUENT_OTEL_PROTO}/include)
CPROF_OPTION(FLUENT_PROTO_METRICS "on")
CPROF_OPTION(FLUENT_PROTO_PROFILES "on")
CPROF_OPTION(FLUENT_PROTO_EXAMPLES "off")
add_subdirectory(lib/fluent-otel-proto)
CPROF_DEFINITION(CPROF_HAVE_FLUENT_OTEL_PROTO)
Expand Down
Loading
Loading