Flub/reset rtt #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a super hacky way to be able to reset the right bits of the congestion controller.
4 tasks
|
@flub given the actual diff is not that large, maybe we should open a Draft PR to |
|
@dignifiedquire Yep, we should try, though in the current form I guess it's unlikely because I'm explicitly making internal things public. |
There was too much state in the path that was being thrown away. Possibly there is not enough being reset right now, especially the mtu might matter. But it at least works.
flub
added a commit
that referenced
this pull request
May 2, 2024
This is mostly copied from upstream, with a bit of changes inspired by our own usual CI setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of n0-computer/iroh#2234