-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQN for flow #964
base: master
Are you sure you want to change the base?
DQN for flow #964
Conversation
Ya I have zero ideas why the build fails, it works on my pc (without the unittest). |
Putting aside the build failure, this sets RLlibs DQN as the default option. We'd prefer you make it so that there's a choice of algorithm, of which DQN is one. You can look at train.py in the flow_maddpg branch for an example. |
Sure, I'll revise it. BTW in that train.py, is the TD3 in setup_exps_rllib same with the one in h-baseline? |
examples/exp_configs/rl/multiagent/multiagent_traffic_light_grid.py
Outdated
Show resolved
Hide resolved
This looks good to me minus comments! @pengyuan-zhou if the changes are made I will merge. |
examples/exp_configs/rl/multiagent/multiagent_traffic_light_grid.py
Outdated
Show resolved
Hide resolved
Hey! I'm really sorry about the state of things here, we are working on getting a new maintainer in the next week or so so this doesn't happen again. |
Hi,
This is a branch to enable DQN (also by ray) for flow.
Currently it supports single agent and multi-agent tests on traffic_light_grid scripts.
Other examples can be easily enabled by modifying corresponding example file, env file and test file, according to the modifications in this branch.
Cheers,
Pengyuan