-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new stackable bin generator #699
Conversation
This looks very nice. You might want to consider a variant that has the "h" edges holding the front from the sides for rougher use. Plastic bins often have an additional vertical front wall that serves as a grip and place to put a label: https://www.morplan.com/gb_en/23563 That might also a nice addition. You are currently using You also need something preventing the bins from sliding side to side and then falling off. You can either have strips to be glues underneath or add Stackable Edges to the back wall, too, - or both. |
@florianfesti Thx, it's very good suggests. I fix code and image, now tray stable! |
But now I look at it and understand that the “limiters” can be glued on and it will look even better inside. |
For the grip and label piece I was thinking about a cross section like this:
To be fair, this is pretty difficult to see on the photo. This way you can grip the bin from underneath and pull it out. Ofc this requires the sides to extend to support this front piece. |
boxes/generators/stackablebin.py
Outdated
if self.outside: | ||
self.x = self.adjustSize(self.x) | ||
self.y = self.adjustSize(self.y) | ||
self.h = self.adjustSize(self.h, e2=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be adjustsize(self.h, "s", "S") to adjust for the stackable edges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
OK, I added a few more fixes. I was pretty busy last week. So it's easier to just drop the changes now and here. After agreeing that we are happy with the result the patches should all be squashed into one. |
@florianfesti Looks good, thanks |
7436827
to
46d95ae
Compare
OK, squashed most commits. I moved to the build in bottom stabilizers after fixing them. They are a bit shorter to they work with stackable edges all around. They still should be fine here. |
46d95ae
to
c3a28ca
Compare
OK; this has gone on long enough. Thanks for all your work! |
A regular box that can be stacked on top of each other.