New generator: Shadowbox #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this looks gorgeous! There is still a left over print in line 103. Otherwise this looks really good! |
|
Whoops, thanks for catching the print statement. Fixed! |
The frame and spacers necessary to display a shadowbox / lightbox.
|
OK, squashed the patches and added a bit nicer commit message. Thanks for the patch and these beautiful pictures! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can find some great vectors online to cut out layers for a shadowbox (also called a lightbox), such as this one here:
https://3axis.co/laser-cut-my-neighbor-totoro-3d-lightbox-lamp-cdr-file/eoxldrxo/
But once you've cut out the paper sheets, you need some kind of frame to space and mount them into. That's what this is.