Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use selectorLabels in pdb #184

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: use selectorLabels in pdb #184

merged 1 commit into from
Nov 13, 2024

Conversation

OcamsRazor
Copy link
Contributor

Switch to flipt.selectorLabels in the pdb as all requirements from matchLabels are ANDed together (docs). If flipt.labels has other labels configured, the pdb will never match.

helm-charts/charts/flipt/templates/deployment.yaml

Lines 21 to 25 in 0ac3dd2

template:
metadata:
annotations: {{- include "common.classes.podAnnotations" . | nindent 8 }}
labels:
{{- include "flipt.selectorLabels" . | nindent 8 }}

GeorgeMac
GeorgeMac approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you!

@GeorgeMac GeorgeMac merged commit 46bff26 into flipt-io:main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OcamsRazor @GeorgeMac