Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include servicemonitor additional labels to template #153

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

nfnsq
Copy link
Contributor

@nfnsq nfnsq commented Jul 8, 2024

Additional labels that can be used so ServiceMonitor resource can be discovered by Prometheus

.Values.metrics.serviceMonitor.labels is already defined in values.yaml but was not used

Additional labels that can be used so ServiceMonitor resource can be discovered by Prometheus
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @nfnsq

@GeorgeMac GeorgeMac enabled auto-merge July 8, 2024 18:41
@GeorgeMac GeorgeMac merged commit e38f156 into flipt-io:main Jul 8, 2024
2 checks passed
@nfnsq nfnsq deleted the service-monitor-labels branch July 9, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants