feat: allow specifying additional pod labels #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we just need a version bump on the chart @tcolgate for CI to pass. Thank you!! 🙌🏻 |
|
Ah this just needs a version bump. Mind making this a |
Signed-off-by: Tristan Colgate-McFarlane <[email protected]>
|
Cheers for this, any idea when the chart might get published (I have had to fork the chart locally for one of our projects). |
|
I have a feeling the chart version should be immediately available with that tag you added @tcolgate 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional pod labels are often needed, for instance, when configuring Istio injection.