Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories are loaded the same as Storybooks #7

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

vocksel
Copy link
Contributor

@vocksel vocksel commented Oct 31, 2024

Problem

The loadStorybookModule function works a bit differently from loadStory in that it will throw on any issues. loadStory should do the same for consistency

Solution

I've updated the API to remove loadStory in favor of loadStoryModule which functions the same as loadStorybookModule

I also was given a vision that made it clear how to handle Hoarcekat stories, so those work now in our e2e suite too

@vocksel vocksel marked this pull request as ready for review October 31, 2024 20:26
@vocksel vocksel merged commit 290c65d into main Oct 31, 2024
3 checks passed
@vocksel vocksel deleted the load-stories-same-as-storybooks branch October 31, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant