Add E2E tests #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Wally doesn't provide a great experience when iterating on a package from a consumer (flipbook). I'm finding myself having to go back-and-forth between flipbook and Storyteller to get everything lined up. Instead, I want to introduce some end-to-end tests to make it easier to validate that what flipbook expects is what Storyteller expects
Solution
This PR got away from me a bit. The bulk of the work is introducing the
e2efolder with Stories to test behavior. I've also made some API adjustments to account for bugs I hit along the way.With this, all stories except Fusion and Hoarcekat are passing. Since this PR is so large already, I'm going to merge as-is and work through the remaining issues later on