Fix crash from remembering stories that no longer exists #314
+120
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When Flipbook attempts to reopen the last story but it does not exist in the DM (either removed from the project or swapping to a whole new experience) Flipbook will crash
Solution
This boils down to an issue in
getInstanceFromFullName
where the loop does not exit in cases where the lookahead failsChecklist
lune run test
locally before merging