Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash from remembering stories that no longer exists #314

Merged

Conversation

vocksel
Copy link
Collaborator

@vocksel vocksel commented Dec 18, 2024

Problem

When Flipbook attempts to reopen the last story but it does not exist in the DM (either removed from the project or swapping to a whole new experience) Flipbook will crash

Solution

This boils down to an issue in getInstanceFromFullName where the loop does not exit in cases where the lookahead fails

Checklist

  • Ran lune run test locally before merging

Sorry, something went wrong.

@vocksel vocksel merged commit a1b51d9 into main Dec 18, 2024
6 checks passed
@vocksel vocksel deleted the fix-crash-from-remembering-instance-that-no-longer-exists branch December 18, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant