Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return home when navigating to same view #304

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

vocksel
Copy link
Collaborator

@vocksel vocksel commented Dec 9, 2024

Problem

When navigating to About or Settings it feels like toggling the same button should do something. Right now it does not

Solution

When toggling the same screen, return home. This feels a bit better on the UX side

Resolves #281

Checklist

  • Ran lune run test locally before merging

@vocksel vocksel marked this pull request as ready for review December 9, 2024 15:31
@vocksel vocksel merged commit 56e3e95 into main Dec 9, 2024
6 checks passed
@vocksel vocksel deleted the return-home-when-navigating-to-same-view branch December 9, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigating to the same page should act as a toggle
1 participant