Inject build information when compiling #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It can be useful to know the version, channel, and commit hash for a given build of Flipbook, especially to help when debugging. We only include the version right now, the other two would be useful
Solution
Created a new BuildInfo component which gets mounted on AboutView. It leverages some new globals that get injected during the darklua build step.
I've also removed the inclusion of
wally.tomlin the Flipbook plugin build since the only info we were using was the version, and that's now supplied via_G.BUILD_VERSIONChecklist
lune run testlocally before merging