Patch for Search Filtering Feature #237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is a continuation of the work done in PR #231. It aims to address the incomplete fix I implemented in my previous PR.
The problem addressed by this PR pertains to the handling of 'story' nodes in our component tree. In the current implementation, 'story' nodes, which inherently do not have any children, are incorrectly subjected to a descendants check. This results in the
isEmpty
flag always being set to true for 'Story' nodes.Solution
The main changes in this PR include:
While the changes introduced in this PR could have been implemented within the existing component, I chose to refactor them into a separate module, so it's easier to test.
Checklist
./bin/test.sh
locally./bin/analyze.sh
locally