Create a file for each renderer #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're requiring the react-spring package, so the variable name should reflect that
# Problem Discovered when hoisting up types for Wally packages that there's several type errors to resolve # Solution This PR adds `wally-package-types` and a new `bin/wally-install.sh` script for installing packages and hoisting up types at the same time. All of this is integrated into CI, and relevant analysis errors have been patched # Checklist - [ ] Ran `./bin/test.sh` locally before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the problem you are trying to solve
Solution
Describe the solution you came up with
Checklist
./bin/test.shlocally before merging