Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tests can only be run manually via
./bin/test.sh
which is usually good enough, but it would be helpful to have tests run when files are changedSolution
Tests are now run in Studio when using the dev project, and when using an accompanying build and watch command this will allow tests to run on file changes
To get this all working I've made some pretty extensive changes:
DEV_MODE
BoolValue to replaceconstants.IS_DEV_MODE
. This BoolValue is only set indev.project.json
useZoom
,useDescendants
,useEvent
, andstores.spec.lua
to get everything passing in Studiostories.spec.lua
was tricky, and I wound up creating a bunch of helper functions for the discovery and loading of storybooks and stories. With tests!Also some other minor changes I made are:
Checklist
./bin/test.sh
locally before merging