Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some memory leaks in tests #1423

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

rburing
Copy link
Contributor

@rburing rburing commented Sep 8, 2023

This fixes some memory leaks in tests which were relatively easy to track down. This is not really important by itself (and it doesn't affect user code), but it will allow focusing on the more interesting leaks.

Maybe in the future CI could check for leaks (though it may have a big resource cost).

@fredrik-johansson
Copy link
Collaborator

Thanks!

Maybe in the future CI could check for leaks (though it may have a big resource cost).

It should be possible with a really small FLINT_TEST_MULTIPLIER and perhaps explicitly disabling certain slow tests.

@fredrik-johansson fredrik-johansson merged commit 993402e into flintlib:trunk Sep 8, 2023
13 checks passed
@rburing rburing deleted the fix_some_test_leaks branch September 8, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants