Merge pull request #1416 from oscarbenjamin/pr_mingw_tmp

Remove TMPDIR and use Win API on Windows

.github/workflows/CI.yml

@@ -470,9 +470,7 @@ jobs:
       - name: "Configure"
         run: |
           ./bootstrap.sh
-          # We need to specify TMPDIR as we do not have write access to the
-          # CI's /tmp directory.
-          ./configure CC=${CC} CFLAGS="${CFLAGS}" TMPDIR="." ${EXTRA_OPTIONS}
+          ./configure CC=${CC} CFLAGS="${CFLAGS}" ${EXTRA_OPTIONS}
 
       - name: "Compile library"
         run: |

CMake/cmake_config.h.in

@@ -18,8 +18,6 @@
 
 #cmakedefine01 FLINT_USES_FENV
 
-#define FLINT_TMPDIR "@FLINT_TMPDIR@"
-
 #ifdef _MSC_VER
 #define access _access
 #define strcasecmp _stricmp

CMakeLists.txt

@@ -54,13 +54,6 @@ if(CMAKE_BUILD_TYPE STREQUAL Debug)
   set(FLINT_WANT_ASSERT ON)
 endif()
 
-# temporary directory
-if(NOT DEFINED TMPDIR)
-    set(FLINT_TMPDIR "/tmp" CACHE STRING "Path to a directory meant for temporary files for host system. Only relevant if host do not have read and write access to /tmp [default=/tmp].")
-else()
-    set(FLINT_TMPDIR "${TMPDIR}" CACHE STRING "Path to a directory meant for temporary files for host system. Only relevant if host do not have read and write access to /tmp [default=/tmp].")
-endif()
-
 # pthread configuration
 
 if(MSVC)

configure.ac

@@ -475,15 +475,6 @@ AC_ARG_VAR(ABI, [Desired ABI])
 
 AC_ARG_VAR(LDCONFIG, [ldconfig tool])
 
-AC_ARG_VAR(TMPDIR, [Specify directory meant for temporary files for host system. Only relevant if host do not have read and write access to /tmp [default=/tmp].])
-
-if test -z "$TMPDIR";
-then
-    TMPDIR="/tmp"
-fi
-
-AC_DEFINE_UNQUOTED([FLINT_TMPDIR], ["$TMPDIR"], [Define to set the default directory for temporary files])
-
 ################################################################################
 # check programs and system
 ################################################################################

src/qsieve/factor.c

@@ -32,6 +32,11 @@
 #include "fmpz_vec.h"
 #include "qsieve.h"
 
+/* Use Windows API for temporary files under MSVC and MinGW */
+#if (defined(__WIN32) && !defined(__CYGWIN__)) || defined(_MSC_VER)
+#include <windows.h>
+#endif
+
 int compare_facs(const void * a, const void * b)
 {
    fmpz * x = (fmpz *) a;
@@ -58,8 +63,8 @@ void qsieve_factor(fmpz_factor_t factors, const fmpz_t n)
     fmpz_t temp, temp2, X, Y;
     slong num_facs;
     fmpz * facs;
-#if (defined(__WIN32) && !defined(__CYGWIN__) && !defined(__MINGW32__) && !defined(__MINGW64__)) || defined(_MSC_VER)
-    const char * tmpnam_ret;
+#if (defined(__WIN32) && !defined(__CYGWIN__)) || defined(_MSC_VER)
+    char temp_path[MAX_PATH];
 #else
     int fd;
 #endif
@@ -209,17 +214,23 @@ void qsieve_factor(fmpz_factor_t factors, const fmpz_t n)
     pthread_mutex_init(&qs_inf->mutex, NULL);
 #endif
 
-#if (defined(__WIN32) && !defined(__CYGWIN__) && !defined(__MINGW32__) && !defined(__MINGW64__)) || defined(_MSC_VER)
-    tmpnam_ret = tmpnam(NULL);
-    if (tmpnam_ret == NULL)
-        flint_throw(FLINT_ERROR, "tmpnam failed\n");
-
-    strcpy(qs_inf->fname, tmpnam_ret);
-    qs_inf->siqs = fopen(qs_inf->fname, "w");
+#if (defined(__WIN32) && !defined(__CYGWIN__)) || defined(_MSC_VER)
+    if (GetTempPathA(MAX_PATH, temp_path) == 0)
+    {
+        flint_printf("Exception (qsieve_factor). GetTempPathA() failed.\n");
+        flint_abort();
+    }
+    /* uUnique = 0 means the we *do* want a unique filename (obviously!). */
+    if (GetTempFileNameA(temp_path, "siq", /*uUnique*/ 0, qs_inf->fname) == 0)
+    {
+        flint_printf("Exception (qsieve_factor). GetTempFileNameA() failed.\n");
+        flint_abort();
+    }
+    qs_inf->siqs = (FLINT_FILE *) fopen(qs_inf->fname, "w");
     if (qs_inf->siqs == NULL)
         flint_throw(FLINT_ERROR, "fopen failed\n");
 #else
-    strcpy(qs_inf->fname, FLINT_TMPDIR "/siqsXXXXXX");
+    strcpy(qs_inf->fname, "/tmp/siqsXXXXXX"); /* must be shorter than fname_alloc_size in init.c */
     fd = mkstemp(qs_inf->fname);
     if (fd == -1)
         flint_throw(FLINT_ERROR, "mkstemp failed\n");
@@ -228,6 +239,16 @@ void qsieve_factor(fmpz_factor_t factors, const fmpz_t n)
     if (qs_inf->siqs == NULL)
         flint_throw(FLINT_ERROR, "fdopen failed\n");
 #endif
+    /*
+     * The code here and in large_prime_variant.c opens and closes the file
+     * qs_inf->fname in several different places. On Windows all file handles
+     * need to be closed before the file can be removed in cleanup at function
+     * exit. The invariant that needs to be preserved at each open/close is
+     * that either
+     *    qs_inf->siqs is NULL and there are no open handles to the file,
+     * or
+     *    qs_inf->siqs is not NULL and is the *only* open handle to the file.
+     */
 
     for (j = qs_inf->small_primes; j < qs_inf->num_primes; j++)
     {
@@ -465,8 +486,11 @@ void qsieve_factor(fmpz_factor_t factors, const fmpz_t n)
     flint_give_back_threads(qs_inf->handles, qs_inf->num_handles);
 
     flint_free(sieve);
-    if (remove(qs_inf->fname))
+    if (qs_inf->siqs != NULL && fclose((FILE *) qs_inf->siqs))
+        flint_throw(FLINT_ERROR, "fclose fail\n");
+    if (remove(qs_inf->fname)) {
         flint_throw(FLINT_ERROR, "remove fail\n");
+    }
     qsieve_clear(qs_inf);
     qsieve_linalg_clear(qs_inf);
     qsieve_poly_clear(qs_inf);

src/qsieve/init.c

@@ -13,21 +13,19 @@
 #include "fmpz.h"
 #include "qsieve.h"
 
-#if (defined(__WIN32) && !defined(__CYGWIN__) && !defined(__MINGW32__) && !defined(__MINGW64__)) || defined(_MSC_VER)
-# ifndef MAX_PATH
-#  define MAX_PATH 260
-# endif
+#if (defined(__WIN32) && !defined(__CYGWIN__)) || defined(_MSC_VER)
+#include <windows.h>
 #endif
 
 void qsieve_init(qs_t qs_inf, const fmpz_t n)
 {
     size_t fname_alloc_size;
     slong i;
 
-#if (defined(__WIN32) && !defined(__CYGWIN__) && !defined(__MINGW32__) && !defined(__MINGW64__)) || defined(_MSC_VER)
+#if (defined(__WIN32) && !defined(__CYGWIN__)) || defined(_MSC_VER)
     fname_alloc_size = MAX_PATH;
 #else
-    fname_alloc_size = sizeof(FLINT_TMPDIR "/siqsXXXXXX");
+    fname_alloc_size = 20;
 #endif
     qs_inf->fname = (char *) flint_malloc(fname_alloc_size); /* space for filename */
 

src/qsieve/large_prime_variant.c

@@ -503,7 +503,11 @@ int qsieve_process_relation(qs_t qs_inf)
     relation_t * rlist;
     int done = 0;
 
+    if (qs_inf->siqs != NULL && fclose((FILE *) qs_inf->siqs))
+        flint_throw(FLINT_ERROR, "fclose fail\n");
     qs_inf->siqs = (FLINT_FILE *) fopen(qs_inf->fname, "r");
+    if (qs_inf->siqs == NULL)
+        flint_throw(FLINT_ERROR, "fopen fail\n");
 
 #if QS_DEBUG & 64
     printf("Getting relations\n");
@@ -528,7 +532,9 @@ int qsieve_process_relation(qs_t qs_inf)
         }
     }
 
-    fclose((FILE *) qs_inf->siqs);
+    if(fclose((FILE *) qs_inf->siqs))
+        flint_throw(FLINT_ERROR, "fclose fail\n");
+    qs_inf->siqs = NULL;
 
 #if QS_DEBUG & 64
     printf("Removing duplicates\n");
@@ -581,7 +587,11 @@ int qsieve_process_relation(qs_t qs_inf)
     {
        qs_inf->edges -= 100;
        done = 0;
+       if (qs_inf->siqs != NULL && fclose((FILE *) qs_inf->siqs))
+           flint_throw(FLINT_ERROR, "fclose fail\n");
        qs_inf->siqs = (FLINT_FILE *) fopen(qs_inf->fname, "a");
+       if (qs_inf->siqs == NULL)
+           flint_throw(FLINT_ERROR, "fopen fail\n");
     } else
     {
        done = 1;