Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187 Add details on interactions between Scala and Kryo #193

Conversation

arnaud-daroussin
Copy link
Contributor

As describe in the issue and this comment #187 (comment), here is a proposal to add more details of interactions between Scala and Kryo and explain the case where the duplication of case objects can occur.

First point of comment is addressed by adding some context:

- has no silent fallback to Kryo: it will just fail the compilation in a case when serializer cannot be made
+ `TypeInformation` derivation macro has no silent fallback to Kryo: it will just fail the compilation in a case when serializer cannot be made

Second point:

  • add explanations in "Supported Flink versions" section where the suggestion of removing flink-scala dependency was made.
  • Add more details in new "Interaction with Flink's type system" section, with an explicit warning when flink-scala dependency is removed and Kryo is used.

As a first step for the third point, recommend to disable Kryo to fail-fast, at least in a test environment.

@arnaud-daroussin arnaud-daroussin changed the title #187 Add details of interactions between Scala and Kryo #187 Add details on interactions between Scala and Kryo Jan 2, 2025
@novakov-alexey
Copy link
Collaborator

Perfect. Thank you very much for this explanation, @arnaud-daroussin .

@novakov-alexey novakov-alexey merged commit d9588d0 into flink-extended:master Jan 3, 2025
5 checks passed
@arnaud-daroussin arnaud-daroussin deleted the doc-interactions-with-Kryo branch January 3, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants