Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flink kubernetes application example #27

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Add flink kubernetes application example #27

merged 1 commit into from
Jun 27, 2023

Conversation

Sxnan
Copy link
Collaborator

@Sxnan Sxnan commented Jun 26, 2023

No description provided.

@Sxnan Sxnan force-pushed the kube-app-example branch 10 times, most recently from 9faa8b0 to e33dfa3 Compare June 26, 2023 09:34
@Sxnan Sxnan marked this pull request as ready for review June 26, 2023 09:36
@Sxnan Sxnan force-pushed the kube-app-example branch from e33dfa3 to a815dbd Compare June 26, 2023 09:52
@Sxnan Sxnan changed the title Add kubernetes application example Add flink kubernetes application example Jun 27, 2023
@Sxnan Sxnan self-assigned this Jun 27, 2023
@Sxnan Sxnan requested a review from lindong28 June 27, 2023 01:32
@Sxnan
Copy link
Collaborator Author

Sxnan commented Jun 27, 2023

@lindong28 Could you review this PR?

lindong28
lindong28 reviewed Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@lindong28 lindong28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM overall.

Can you add a link to this example in the main README?

@Sxnan Sxnan force-pushed the kube-app-example branch from a815dbd to bd3d8ec Compare June 27, 2023 02:39
@Sxnan
Copy link
Collaborator Author

Sxnan commented Jun 27, 2023

@lindong28 I added the link to the main README. And I added issue #28 to reduce the CI run time. Could you take another look?

@Sxnan Sxnan requested a review from lindong28 June 27, 2023 03:26
@lindong28
Copy link
Collaborator

Thanks for the update. LGTM.

@lindong28 lindong28 merged commit c9d4ec8 into flink-extended:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindong28 lindong28 Awaiting requested review from lindong28

Assignees

@Sxnan Sxnan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sxnan @lindong28