Improve MockTransport

[ebisbe]

Readme updates

1. Right now params are mandatory even if empty or not needed ( like flickr.test.login case ). Not sure if that is the intended case.
2. Missing response part.

MockTransport update

The test example is just a happy example with almost no real use case when testing another app using this package. A more likelihood scenario would be that we can require multiple queries on the same test. The current implementation of the MockTransport does not allow this. The proposal should be backwards compatible while allowing to add multiple responses to the MockTransport and returning once each time in the same order they have been added.

Example:

const transport = new MockTransport(`oauth_token=token&oauth_token_secret=secret&user_nsid=${flickrId}`)
transport.addMock({
    person: {
      username: { _content: 'Username' },
      ispro: 1,
    },
    stat: 'ok',
  })

  FetchTransport.mockImplementationOnce(() => transport)

[jeremyruppel]

Thank you! This looks excellent, and definitely a lot more usable than having to create a new Flickr with a new MockTransport for every test. One suggestion might be to include a .clear() or .reset() for clearing out the responses array between tests, since MockTransport will now be stateful, but I think I'm going to merge this as is. Let me know if you come up with any other quality-of-life improvements for test scenarios

[jeremyruppel]

@ebisbe we're now requiring signed commits for contributions. Is this something you can set up on your end?

[ebisbe]

@jeremyruppel I can but I'm not sure what I have to do. I'll have to figure it out. If you have a guide ( link ) that you already followed that would be perfect for me to use.

[ebisbe]

Btw, I can update with the reset / clear option and a signed commit. I'm using a fork so there's no rush on my end.

[jeremyruppel]

Sure thing! The official guide can be found here.

[jeremyruppel]

Oh I see, b47bec2 still isn't signed. Mind giving it a squash or rebase to sign it?

[ebisbe]

@jeremyruppel done