Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return json response on error #168

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Return json response on error #168

merged 1 commit into from
Oct 3, 2024

Conversation

ebisbe
Copy link
Contributor

@ebisbe ebisbe commented Oct 3, 2024

Once we parse the res response with const json = await parser.parse(res) it cannot be parsed again. So we must return the JSON response to be able to understand the issue we are facing. Get the error or stat

@jeremyruppel
Copy link
Member

Nice catch!

@jeremyruppel jeremyruppel merged commit 1b0c3b4 into flickr:main Oct 3, 2024
2 checks passed
@ebisbe ebisbe deleted the ebg/fix-error-response branch October 14, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyruppel jeremyruppel jeremyruppel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebisbe @jeremyruppel