Skip to content

Commit

Permalink
orch prepare warn print for failures
Browse files Browse the repository at this point in the history
  • Loading branch information
flhofer committed Jun 22, 2024
1 parent 81c39d6 commit 865ec3a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
12 changes: 7 additions & 5 deletions src/orchestrator/prepare.c
Original file line number Diff line number Diff line change
Expand Up @@ -825,12 +825,14 @@ prepareEnvironment(prgset_t *set) {

if (numa_bitmask_isbitset(con, i)){ // filter by online/existing

// TODO: use return values for messaging
(void)setCPUgovernor(set, i);
if (setCPUgovernor(set, i))
warn("Could not configure CPU governor. Expect performance loss!");

(void)adjustCPUfreq(set, i);
if (adjustCPUfreq(set, i))
warn("Could not configure CPU-frequency. Expect performance loss!");

(void)setCPUpowerQos(set, i);
if (setCPUpowerQos(set, i))
warn("Could not configure CPU PM-QoS latency. Expect performance loss!");

// if smi is set, read SMI counter
if(set->smi) {
Expand Down Expand Up @@ -970,7 +972,7 @@ prepareEnvironment(prgset_t *set) {
if (KV_NOT_SUPPORTED == set->kernelversion)
warn("Running on unknown kernel version; Trying generic configuration..");

if (resetRTthrottle (set, -1)){ // TODO: throttle is limited if no affinity lock is set
if (resetRTthrottle (set, -1)){
// reset failed, let's try a CGroup reset first?? partitioned should work
cont( "trying to reset Docker's CGroups CPU's to %s first", set->affinity);
resetContCGroups(set, constr, set->numa);
Expand Down
2 changes: 1 addition & 1 deletion src/orchestrator/resmgnt.c
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ resetRTthrottle (prgset_t *set, int percent){
char buf[20]; // temporary stack buffer

// all modes except Dynamic, set to -1 = unconstrained
if (-1 == percent){
if (-1 == percent){ // TODO: throttle is limited if no affinity lock is set
cont( "Set real-time bandwidth limit to (unconstrained)..");
value = RTLIM_UNL;
}
Expand Down

0 comments on commit 865ec3a

Please sign in to comment.