properly set enginesBooted flag after boot callbacks have run

fleetbase · Oct 3, 2024 · 4b6adca · 4b6adca
1 parent 6704079
commit 4b6adca
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/addon/services/universe.js b/addon/services/universe.js
@@ -1867,8 +1867,9 @@ export default class UniverseService extends Service.extend(Evented) {
                 await tryBootEngine(extension);
             }
 
-            this.runBootCallbacks(owner);
-            this.enginesBooted = true;
+            this.runBootCallbacks(owner, () => {
+                this.enginesBooted = true;
+            });
         });
     }
 
@@ -1953,8 +1954,9 @@ export default class UniverseService extends Service.extend(Evented) {
                 await tryBootEngine(extension);
             }
 
-            this.runBootCallbacks(owner);
-            this.enginesBooted = true;
+            this.runBootCallbacks(owner, () => {
+                this.enginesBooted = true;
+            });
         });
     }
 
@@ -2004,7 +2006,11 @@ export default class UniverseService extends Service.extend(Evented) {
         for (let i = 0; i < this.bootCallbacks.length; i++) {
             const callback = this.bootCallbacks[i];
             if (typeof callback === 'function') {
-                callback(this, appInstance);
+                try {
+                    callback(this, appInstance);
+                } catch (error) {
+                    debug(`Engine Boot Callback Error: ${error.message}`);
+                }
             }
         }