Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add current Node version to CI yaml #72

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

RobertPechaCZ
Copy link
Contributor

Why?

Clear and short explanation here.

How?

  • Done A (replace with a breakdown of the steps)
  • Done B
  • Done C

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • You have manually tested
  • You have provided tests

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)

Preview?

Optionally, provide the preview url here

@RobertPechaCZ RobertPechaCZ self-assigned this Nov 19, 2024
Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: a903418

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@fleek-platform/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heldrida heldrida changed the title feat: add current Node version to CI yaml feat: 🎸 add current Node version to CI yaml Nov 21, 2024
Copy link
Member

@heldrida heldrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright! I'd probably throw if process.version's fails.

… package.json for `engines.node` and remove non-semver characters
@RobertPechaCZ RobertPechaCZ merged commit f77d4b8 into develop Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants