Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: styling revamp #65

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: styling revamp #65

wants to merge 5 commits into from

Conversation

bcamarneiro
Copy link

@bcamarneiro bcamarneiro commented Oct 14, 2024

Why?

Updated styling in accordance to https://www.figma.com/design/O88f6EhtFC1hpglVKZ2QCN/Fleek-Pages?node-id=769-9437&m=dev

image

preview:
image

Also updated some dependencies

How?

  • updated deps
  • isolated some styles in their own css files to simplify maintenance
  • overridden styles; changed logo;

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content is linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The UI is escaping output (to prevent XSS)
  • Sensitive data has been identified and is being protected properly

References?

Optionally, provide references such as links

Preview?

Optionally, provide the preview url here

@bcamarneiro bcamarneiro changed the title Feature/style revamp feat: styling revamp Oct 14, 2024
Copy link

@victorgaard victorgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job on the first PR! 🚀

added a few minor comments regarding design

src/components/Author/styles.css Outdated Show resolved Hide resolved
src/css/breadcrumbs.css Outdated Show resolved Hide resolved
docs/Open-source/contributing.md Outdated Show resolved Hide resolved
src/css/custom.css Show resolved Hide resolved
@bcamarneiro bcamarneiro force-pushed the feature/style-revamp branch 5 times, most recently from 86d91de to 338df2a Compare October 16, 2024 14:39
@bcamarneiro bcamarneiro self-assigned this Oct 16, 2024
@bcamarneiro bcamarneiro force-pushed the feature/style-revamp branch 6 times, most recently from 77c945f to 793b00c Compare October 20, 2024 15:41
@bcamarneiro bcamarneiro force-pushed the feature/style-revamp branch 11 times, most recently from b8aa4ee to e6e4494 Compare October 27, 2024 11:27
@bcamarneiro bcamarneiro force-pushed the feature/style-revamp branch 7 times, most recently from e74d469 to 4cdb91e Compare November 1, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants