Fix some dialog and font size concerns. #40
Conversation
paulblessing
commented
Mar 27, 2014
paulblessing
commented
- Add horizontal layout weights to the picker dialogs in layout-land so that the pickers don't go off screen on smaller devices.
- Copy the original picker layout-land files to layout-w500dp-land where there is enough room for the original layout.
- Update time picker label font sizes from sp to dip for smaller screens so that double-digit hours do not disappear when the Font Size is set to Huge.
- Add horizontal layout weights to the picker dialogs in layout-land so that the pickers don't go off screen on smaller devices. - Copy the original picker layout-land files to layout-w500dp-land where there is enough room for the original layout. - Update time picker label font sizes from sp to dip for smaller screens so that double-digit hours do not disappear when the Font Size is set to Huge.
|
why do you change time_label_size unit from sp to dip ? |
To keep the text at a fixed size even if the device's Font Size is set to Huge. Currently if the Font Size is set to Huge and a two-digit hour is chosen in the time picker, the hour text disappears completely. I'm fine with trying to fix this a different way. |
|
Yep thanks :) |
|
I had created an issue based on the bug Paul describes where the 2 digit hour does not show when the system wide font is changed. I would highly suggest approving his commit or finding something else that will work. It occurs on both tablets and phones if their font is set to anything above "normal" I pulled in the fixes he made with the dip instead of sp and it fixed the problem for me. |
|
I'm having trouble coming up with another way of keeping the text from resizing besides changing the units from sp to dip. There's even precedent in this project for doing so (in the default |
