Skip to content

Commit

Permalink
Update FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
swick committed Jan 19, 2024
1 parent 051e9d4 commit 7b0cc56
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/xdp-utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,9 @@ char * xdp_app_info_get_instance (XdpAppInfo *app_info);
gboolean xdp_app_info_is_host (XdpAppInfo *app_info);
gboolean xdp_app_info_is_flatpak (XdpAppInfo *app_info);
XdpAppInfoKind xdp_app_info_get_kind (XdpAppInfo *app_info);
// FIXME Should fallback to current impls. Containers1 metadata could be used here.
// FIXME Does remapping based on flatpak metadata. We might be able to use Containers1 metadata but this could be tricky.
char * xdp_app_info_remap_path (XdpAppInfo *app_info,
const char *path);
// FIXME PID/TID mapping: what we want is dbus->pidfd->pidns, but can't because pidfd is from proxy. Use flatpak/bwrap specific path for now.
gboolean xdp_app_info_map_pids (XdpAppInfo *app_info,
pid_t *pids,
guint n_pids,
Expand All @@ -112,7 +111,7 @@ GAppInfo * xdp_app_info_load_app_info (XdpAppInfo *app_info);
char ** xdp_app_info_rewrite_commandline (XdpAppInfo *app_info,
const char *const *commandline,
gboolean quote_escape);
// FIXME TODO
// FIXME Needs investigation. Not even sure what it does.
char *xdp_app_info_get_tryexec_path (XdpAppInfo *app_info);

G_DEFINE_AUTOPTR_CLEANUP_FUNC(XdpAppInfo, xdp_app_info_unref)
Expand Down

0 comments on commit 7b0cc56

Please sign in to comment.