Add zypak support #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasinvein
force-pushed
the
zypak
branch
2 times, most recently
from
79d3bb8
to
019611a
Compare
Outer is the entrypoint, it handles initial cli args and opening readmes Inner wrapper only handles setting up the environment.
This support the new changes on zypak-helper https://github.com/refi64/zypak/blob/ded79a2f8a509adc21834b95a9892073d4a91fdc/zypak-wrapper.sh#L12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting Zypak requires splitting the wrapper into two parts: "inner" (
editor-wrapper.sh) and "outer" (editor.sh).The reason for this is that we need to setup cli args only when the user launches the app manually, but not when Electron reexecs itself.
editor-wrapper.shis responsible for setting up the environment; it's passed to the app asCHROME_WRAPPERand is always used, even on app reexeceditor.shserves as an entrypoint, responsible for handling first-launch readmes and adding default cli args