Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromiumchecker: Switch prebuilt Clang url to use .tar.xz #440

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

refi64
Copy link
Contributor

@refi64 refi64 commented Sep 18, 2024

The gzip archives aren't produced anymore:

https://chromium-review.googlesource.com/c/chromium/src/+/5544198

@wjt
Copy link
Contributor

wjt commented Sep 19, 2024

======================================================================
FAIL: test_check (tests.test_chromiumchecker.TestChromiumChecker.test_check)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.11/unittest/async_case.py", line 90, in _callTestMethod
    if self._callMaybeAsync(method) is not None:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/unittest/async_case.py", line 112, in _callMaybeAsync
    return self._asyncioRunner.run(
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/home/runner/work/flatpak-external-data-checker/flatpak-external-data-checker/tests/test_chromiumchecker.py", line 51, in test_check
    self.assertRegex(
AssertionError: Regex didn't match: '^[https://commondatastorage.googleapis.com/chromium-browser-clang/Linux_x64/clang-.*\\.tgz$](https://commondatastorage.googleapis.com/chromium-browser-clang/Linux_x64/clang-.*//.tgz$)' not found in 'https://commondatastorage.googleapis.com/chromium-browser-clang/Linux_x64/clang-llvmorg-20-init-1009-g7088a5ed-10.tar.xz'

@refi64
Copy link
Contributor Author

refi64 commented Sep 19, 2024

oops I forgot that test existed (despite me being the one who apparently wrote it), should be fixed now.

@wjt
Copy link
Contributor

wjt commented Sep 19, 2024

Thanks! I don't think the remaining failure is on you :)

@wjt wjt merged commit 6e156e0 into flathub-infra:master Sep 19, 2024
2 of 3 checks passed
@wjt
Copy link
Contributor

wjt commented Sep 19, 2024

Filed #441 for the remaining failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants