Fix tests and add builddeps of python3-apt to Dockerfile #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbhtt
force-pushed
the
fix-tests
branch
3 times, most recently
from
f29c02d
to
e9e5cc1
Compare
bbhtt
changed the title
|
Ok it should be back to the state before #391 |
bbhtt
changed the title
|
Ok, all tests should be fixed now. |
|
The issue with httpbin-go is now fixed mccutchen/go-httpbin#153, I think I can drop the last commit. |
wjt
approved these changes
Nov 8, 2023
| RUN apt-get update && \ | ||
| xargs apt-get install --no-install-recommends -y < dependencies.apt.txt && \ | ||
| apt-get --no-install-recommends -y build-dep python3-apt && \ |
There was a problem hiding this comment.
It feels a bit weird to install the build-deps from apt, but then install the package via pip. I guess that's fine because it makes the requirements.txt usable on non-Debian distros.
There was a problem hiding this comment.
I noticed it too, that pip modules are getting installed twice one by apt then by pip.
Not sure what to do there.
| @@ -4,8 +4,11 @@ ENV DEBIAN_FRONTEND=noninteractive | |||
|
|
|||
| ADD dependencies.apt.txt ./ | |||
|
|
|||
| RUN printf "deb-src http://deb.debian.org/debian bullseye main\ndeb-src http://deb.debian.org/debian-security/ bullseye-security main\ndeb-src http://deb.debian.org/debian bullseye-updates main" >> /etc/apt/sources.list | |||
There was a problem hiding this comment.
I might try a patch to generate this based on the existing lines of /etc/apt/sources.list but this will work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests broke a bit after #391
Trying to fix the installation part of all pip modules at least.