WIP

flat3 · Dec 2, 2024 · b9f8926 · b9f8926
1 parent ed39d6c
commit b9f8926
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 12 deletions.
diff --git a/src/Attributes/LodataNamespace.php b/src/Attributes/LodataNamespace.php
@@ -11,7 +11,7 @@ class LodataNamespace
 {
     protected ?string $name = null;
 
-    public function __construct(string $name = null)
+    public function __construct(?string $name = null)
     {
         $this->name = $name;
     }

diff --git a/src/Controller/Response.php b/src/Controller/Response.php
@@ -39,7 +39,7 @@ abstract class Response extends StreamedResponse
      */
     public $exception;
 
-    public function __construct(callable $callback = null, int $status = 200, array $headers = [])
+    public function __construct(?callable $callback = null, int $status = 200, array $headers = [])
     {
         parent::__construct($callback, $status, $headers);
 

diff --git a/src/Exception/Internal/ParserException.php b/src/Exception/Internal/ParserException.php
@@ -13,7 +13,7 @@
  */
 final class ParserException extends BadRequestException
 {
-    public function __construct(string $message, Lexer $lexer = null)
+    public function __construct(string $message, ?Lexer $lexer = null)
     {
         if ($lexer) {
             $message .= ' at: '.$lexer->errorContext();

diff --git a/src/Exception/Protocol/ProtocolException.php b/src/Exception/Protocol/ProtocolException.php
@@ -30,7 +30,7 @@ abstract class ProtocolException extends RuntimeException implements Responsable
     protected $suppressContent = false;
     protected $originalException = null;
 
-    public function __construct(string $code = null, string $message = null, Throwable $originalException = null)
+    public function __construct(?string $code = null, ?string $message = null, ?Throwable $originalException = null)
     {
         if ($code) {
             $this->odataCode = $code;

diff --git a/src/Transaction/ParameterList.php b/src/Transaction/ParameterList.php
@@ -27,7 +27,7 @@ public function __construct()
      * Parse a string into separate parameters
      * @param  string|null  $text
      */
-    public function parse(string $text = null)
+    public function parse(?string $text = null)
     {
         if (!$text) {
             return;

diff --git a/tests/Helpers/MockPredisConnection.php b/tests/Helpers/MockPredisConnection.php
@@ -11,7 +11,7 @@
 
 class MockPredisConnection extends PredisConnection
 {
-    public function pipeline(callable $callback = null)
+    public function pipeline(?callable $callback = null)
     {
         $pipeline = $this->client()->pipeline();
 

diff --git a/tests/Helpers/StreamingJsonMatches.php b/tests/Helpers/StreamingJsonMatches.php
@@ -33,7 +33,7 @@ protected function recode(string $string): string
         return json_encode(json_decode($string));
     }
 
-    protected function _fail($other, string $description, ComparisonFailure $comparisonFailure = null): void
+    protected function _fail($other, string $description, ?ComparisonFailure $comparisonFailure = null): void
     {
         if ($comparisonFailure === null) {
             $decodedOther = json_decode($other);

diff --git a/tests/Helpers/StreamingJsonMatches/StreamingJsonMatches81.php b/tests/Helpers/StreamingJsonMatches/StreamingJsonMatches81.php
@@ -10,7 +10,7 @@
 
 class StreamingJsonMatches81 extends StreamingJsonMatches
 {
-    public function fail($other, string $description, ComparisonFailure $comparisonFailure = null): never
+    public function fail($other, string $description, ?ComparisonFailure $comparisonFailure = null): never
     {
         $this->_fail($other, $description, $comparisonFailure);
 

diff --git a/tests/Helpers/UseDatabaseAssertions.php b/tests/Helpers/UseDatabaseAssertions.php
@@ -82,7 +82,7 @@ protected function assertNoTransactionsInProgress()
 
 
     // https://github.com/mattiasgeniar/phpunit-query-count-assertions/blob/master/src/AssertsQueryCounts.php
-    protected function assertNoQueriesExecuted(Closure $closure = null): void
+    protected function assertNoQueriesExecuted(?Closure $closure = null): void
     {
         if ($closure) {
             self::trackQueries();
@@ -97,7 +97,7 @@ protected function assertNoQueriesExecuted(Closure $closure = null): void
         }
     }
 
-    protected function assertQueryCountMatches(int $count, Closure $closure = null): void
+    protected function assertQueryCountMatches(int $count, ?Closure $closure = null): void
     {
         if ($closure) {
             self::trackQueries();
@@ -112,7 +112,7 @@ protected function assertQueryCountMatches(int $count, Closure $closure = null):
         }
     }
 
-    protected function assertQueryCountLessThan(int $count, Closure $closure = null): void
+    protected function assertQueryCountLessThan(int $count, ?Closure $closure = null): void
     {
         if ($closure) {
             self::trackQueries();
@@ -127,7 +127,7 @@ protected function assertQueryCountLessThan(int $count, Closure $closure = null)
         }
     }
 
-    protected function assertQueryCountGreaterThan(int $count, Closure $closure = null): void
+    protected function assertQueryCountGreaterThan(int $count, ?Closure $closure = null): void
     {
         if ($closure) {
             self::trackQueries();