Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract buildSettingComponent method into a FormGroup component #3927

Merged
merged 4 commits into from
Apr 6, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 10, 2023

Changes proposed in this pull request:

  • Extracts what the method does into a component reusable across all the admin panel. I pondered moving this to common to allow using on the forum frontend as well, but not sure if the use case for it exists, are there extensions that add forms as in the admin side that could benefit from this?

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added this to the 2.0 milestone Nov 10, 2023
@SychO9 SychO9 requested a review from a team as a code owner November 10, 2023 13:13
@SychO9 SychO9 requested a review from imorland January 22, 2024 17:59
Copy link
Member

@luceos luceos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember having tried using this in the forum frontend at some point. So moving it to common would get an upvote from me.

Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on putting this in common if possible, this is way preferable to writing custom forms by hand.

SychO9 added 2 commits April 6, 2024 14:42
# Conflicts:
#	framework/core/js/src/admin/components/AdminPage.tsx
@SychO9 SychO9 merged commit bf523b2 into 2.x Apr 6, 2024
10 of 29 checks passed
@SychO9 SychO9 deleted the sm/build-setting-component branch April 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants