Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract FormModal from Modal #3922

Merged
merged 1 commit into from
Nov 10, 2023
Merged

chore: extract FormModal from Modal #3922

merged 1 commit into from
Nov 10, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 3, 2023

Changes proposed in this pull request:

  • The current modal component always assumes the contents are part of a form, and therefore its typings require an onsubmit method be filled.
  • The PR extracts a FormModal instead to have a clear separation of read only modals and action modals.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner November 3, 2023 16:18
@SychO9 SychO9 added this to the 2.0 milestone Nov 3, 2023
@SychO9 SychO9 added breaking-changes javascript Pull requests that update Javascript code labels Nov 3, 2023
@imorland imorland merged commit eaabeab into 2.x Nov 10, 2023
21 of 22 checks passed
@imorland imorland deleted the sm/form-modal branch November 10, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants