Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: discussion page showing horizontal scroll on iOS #3821

Merged
merged 3 commits into from
May 8, 2023
Merged

fix: discussion page showing horizontal scroll on iOS #3821

merged 3 commits into from
May 8, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 7, 2023 •
edited
Loading

Fixes #3703

Changes proposed in this pull request:

  • Prevents horizontal scroll of the page.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner May 7, 2023 17:58
@SychO9 SychO9 closed this May 7, 2023
@SychO9 SychO9 deleted the sm/3703-ios-discussion-scrolling branch May 7, 2023 21:39
@SychO9 SychO9 restored the sm/3703-ios-discussion-scrolling branch May 7, 2023 22:20
@SychO9 SychO9 reopened this May 7, 2023
@SychO9 SychO9 merged commit 80b34d1 into main May 8, 2023
@SychO9 SychO9 deleted the sm/3703-ios-discussion-scrolling branch May 8, 2023 08:28
davwheat
davwheat approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posthumous approval :)

@github-actions github-actions bot mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion page scrolling issue on iOS
2 participants
@SychO9 @davwheat