feat: kubernetes relationship by lookup #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
feat/kubernetes-link-resources
branch
2 times, most recently
from
4683347 to
e1487f9
Compare
moshloop
reviewed
Nov 27, 2023
|
@adityathebe Could we update the example fixture and maybe add an integration test? |
moshloop
reviewed
Nov 28, 2023
adityathebe
force-pushed
the
feat/kubernetes-link-resources
branch
from
53ae2cd to
faeea56
Compare
moshloop
reviewed
Nov 28, 2023
| Expect(err).To(BeNil()) | ||
|
|
||
| Expect(len(configRelationships)).To(Equal(1)) | ||
| Expect(configRelationships[0].Relation).To(Equal("ConfigMapConfigMap")) |
There was a problem hiding this comment.
I think this should just be ConfigMap
There was a problem hiding this comment.
Aren't we concatenating the kind of the two related objects? Eg (from azure demo):
PodConfigMap
NodePod
GrafanaConfigMap
EKSNode
DaemonSetPod
There was a problem hiding this comment.
We shouldn't be, but we can tackle that later
|
🎉 This PR is included in version 0.0.147 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #320