feat: watch kubernetes events #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshloop
reviewed
Sep 6, 2023
moshloop
reviewed
Sep 6, 2023
- go mod tidy on hack - bug fix. KetOne can return empty object without any error.
- Update versions in lint workflow - Update go version in Docker image
adityathebe
commented
Sep 12, 2023
moshloop
reviewed
Sep 13, 2023
moshloop
reviewed
Sep 13, 2023
moshloop
reviewed
Sep 13, 2023
moshloop
reviewed
Sep 13, 2023
moshloop
reviewed
Sep 13, 2023
moshloop
reviewed
Sep 13, 2023
moshloop
reviewed
Sep 13, 2023
This is because mapstructure doesn't handle the conversion of timestamp (string) to time.Time type
|
@adityathebe Can you rebase this? I think we will also need to cater for https://kubernetes.io/docs/reference/using-api/deprecation-guide/#event-v125 and make v1.25 the minimum version |
adityathebe
force-pushed
the
feat/watch-kubernetes-events
branch
from
37a9d50 to
86235d9
Compare
|
@moshloop This is ready |
|
🎉 This PR is included in version 0.0.172 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #279