On MacOS, always wrap "dtrace" invocation in "arch -arch $native_arch" #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302 by always running
dtrace
as the native architecture. This is accomplished by adding another layer of wrapping in addition tosudo
: thearch
command forces its spawned children to run as the specified architecture.Initially I was doing a lot more in this PR (parsing out the architecture of the target binary to be traced and making dtrace run as that), but it turned out to be unnecessary since is prevented from tracing cross-architecture binaries on MacOS in all circumstances.
Since the
dtrace
binary itself is multi-arch, spawning it inside thearch -arch arm64
command will never fail, but if users do something likecargo flamegraph --root - --target x86_64-apple-darwin
they'll get an error from dtrace itself saying "no" regardless of whether this PR has been applied or not.