Fix linking of sentences in sentence splitter #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't the already implemented Sentence method Line 1115 in ddf3bb3 |
|
@mauryaland Thanks for the hint! I adapted the implementation accordingly. |
helpmefindaname
approved these changes
Jan 26, 2024
|
Changes look good, the failing pipeline seems to be due to unrelated issues, I will look into those further in a separate PR |
|
@mariosaenger thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing linkage of sentences (see issue #3396), i.e., setting the previous and next sentence in the sentence objects, when calling the split method of a sentence splitter.