deps: relax version constraint for konoha #3394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version constraint for konoha.
I'm so sorry that I didn't notice the issue #3059.
I updated konoha that removed the dependency for
importlib-metadata
, let me updaterequirements-dev.txt
.Now konoha only depends on
requests
with the support for Python3.8+ (https://github.com/himkt/konoha/blob/v5.5.2/pyproject.toml#L27).So I think it can be safely used with flair and I update the requirements file.
And I have one question for dependency of
janome
.janome
is only used inJapaneseTokenizer
, which depends onkonoha
, thereforejanome
should be installed in the same place ofkonoha
, I think. There are multiple options:janome
torequirements-dev.txt
janome
fromrequirements.txt
and install withkonoha[janome]
(extras)konoha
torequirements.txt
konoha
fromrequirements-dev.txt
and installkonoha
withkonoha[janome]
(extras)I'd like to a maintainer's opinion.