-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve categories grid #45
base: main
Are you sure you want to change the base?
Conversation
e0d9d56
to
1fbdec5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make a special branch/tag for this one ?
@A-Souhei - what's your motivation for this?
@ChasNelson1990 This follows the same principles as what we did in WAC. Updating "group" and "organization" required a lot of templates modifications so using the po file was a lot less code changes. My question is because may be not every CKAN applications needs this. |
Can we no just have some sort of on / off flag in the extension config? |
@ChasNelson1990 a code in bootstrap.sh is needed for it, if one does not add this code, will that be enough as a way to toggle it on / off? |
Maybe we should have an explicit variable rather than an implicit copy / paste? |
Description
Should we make a special branch/tag for this one ?
Relates fjelltopp/ckanext-who-romania#36
Relates https://github.com/fjelltopp/who-romania-ckan/pull/164
Relates https://github.com/fjelltopp/fjelltopp-infrastructure/pull/329
Closes https://github.com/fjelltopp/who-romania-ckan/issues/146
Checklist
Put an
x
in the boxes that apply to this pull request (you can also fill these out after opening the pull request).You may not need to check all boxes.