Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve categories grid #45

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Improve categories grid #45

wants to merge 14 commits into from

Conversation

A-Souhei
Copy link
Contributor

@A-Souhei A-Souhei commented Dec 3, 2024

Description

  • bigger categories in homepage and group page
  • moved group customization into ckanext-fjelltopp-theme
  • added a .pot file (which can be updated based on extensions, ckan versions ...) that will be programmatically translated using a python and bash files

Should we make a special branch/tag for this one ?

Relates fjelltopp/ckanext-who-romania#36
Relates https://github.com/fjelltopp/who-romania-ckan/pull/164
Relates https://github.com/fjelltopp/fjelltopp-infrastructure/pull/329
Closes https://github.com/fjelltopp/who-romania-ckan/issues/146

image
image
image
image
image

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@A-Souhei A-Souhei self-assigned this Dec 3, 2024
@A-Souhei A-Souhei added the enhancement New feature or request label Dec 3, 2024
@A-Souhei A-Souhei changed the title 146 - Improve categories grid Improve categories grid Dec 4, 2024
@A-Souhei A-Souhei force-pushed the 146-improve-categories-grid branch from e0d9d56 to 1fbdec5 Compare December 5, 2024 12:36
@A-Souhei A-Souhei added the major label Dec 6, 2024
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make a special branch/tag for this one ?

@A-Souhei - what's your motivation for this?

@A-Souhei
Copy link
Contributor Author

A-Souhei commented Dec 9, 2024

@ChasNelson1990 This follows the same principles as what we did in WAC. Updating "group" and "organization" required a lot of templates modifications so using the po file was a lot less code changes.

My question is because may be not every CKAN applications needs this.

@ChasNelson1990
Copy link
Member

My question is because may be not every CKAN applications needs this.

Can we no just have some sort of on / off flag in the extension config?

@A-Souhei
Copy link
Contributor Author

@ChasNelson1990 a code in bootstrap.sh is needed for it, if one does not add this code, will that be enough as a way to toggle it on / off?

@ChasNelson1990
Copy link
Member

@ChasNelson1990 a code in bootstrap.sh is needed for it, if one does not add this code, will that be enough as a way to toggle it on / off?

Maybe we should have an explicit variable rather than an implicit copy / paste?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants