Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into leveled-parallel
Browse files Browse the repository at this point in the history
  • Loading branch information
marvin-j97 committed Nov 27, 2024
2 parents 95bdeb0 + 2dee908 commit 2c8da7d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
14 changes: 6 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,20 +68,18 @@ The disk format is stable as of 1.0.0.

Future breaking changes will result in a major version bump and a migration path.

## Run unit benchmarks

```bash
cargo bench --features bloom,lz4,miniz
```

## License

All source code is licensed under MIT OR Apache-2.0.

All contributions are to be licensed as MIT OR Apache-2.0.

## Development

### Run benchmarks

```bash
cargo bench --features bloom --features lz4 --features miniz
```

## Footnotes

[1] https://rocksdb.org/blog/2017/05/12/partitioned-index-filter.html
Expand Down
6 changes: 3 additions & 3 deletions src/memtable/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,16 @@ impl Memtable {
// NOTE: This range start deserves some explanation...
// InternalKeys are multi-sorted by 2 categories: user_key and Reverse(seqno). (tombstone doesn't really matter)
// We search for the lowest entry that is greater or equal the user's prefix key
// and has the highest seqno (because the seqno is stored in reverse order)
// and has the seqno (or lower) we want (because the seqno is stored in reverse order)
//
// Example: We search for "abc"
//
// key -> seqno
//
// a -> 7
// abc -> 5 <<< This is the lowest key (highest seqno) that matches the range
// abc -> 5 <<< This is the lowest key (highest seqno) that matches the key with seqno=None
// abc -> 4
// abc -> 3
// abc -> 3 <<< If searching for abc and seqno=4, we would get this
// abcdef -> 6
// abcdef -> 5
//
Expand Down

0 comments on commit 2c8da7d

Please sign in to comment.