Remove get all groups endpoint

fizzy-fifs · Oct 25, 2024 · a712466 · a712466
1 parent 9ccf17b
commit a712466
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 27 deletions.
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
diff --git a/src/main/java/com/example/holidayplanner/group/GroupController.java b/src/main/java/com/example/holidayplanner/group/GroupController.java
@@ -38,11 +38,6 @@ public ResponseEntity<Object> create(@RequestBody @Valid Group group, Errors err
         return groupService.create(group);
     }
 
-    @GetMapping
-    @Operation(summary = "Get a list of all groups")
-    public List<Group> getAll() { return groupService.getAll();}
-
-
     @DeleteMapping(path = "/{groupId}")
     public ResponseEntity<String> delete(@PathVariable("groupId") String groupId) {
         return groupService.delete(groupId);

diff --git a/src/main/java/com/example/holidayplanner/group/GroupService.java b/src/main/java/com/example/holidayplanner/group/GroupService.java
@@ -70,7 +70,7 @@ public ResponseEntity<Object> create(Group group) throws JsonProcessingException
 
         userIds.add(groupCreator.getId());
 
-        List<User> users = userRepository.findAllById(userIds);
+        List<User> users = userService.findMultipleUsersByIdInCacheOrDatabase(userIds);
 
         if (users.size() != userIds.size()) {
             return ResponseEntity.badRequest().body("One of the users added does not exist");
@@ -101,18 +101,14 @@ public ResponseEntity<Object> create(Group group) throws JsonProcessingException
             }
         }
 
-        userRepository.saveAll(users);
+        userService.updateMultipleUsersInCacheAndDatabase(users);
 
         ObjectMapper mapper = new ObjectMapper().findAndRegisterModules();
         String groupJson = mapper.writeValueAsString(newGroup);
 
         return ResponseEntity.ok(groupJson);
     }
 
-    public List<Group> getAll() {
-        return groupRepository.findAll();
-    }
-
     public ResponseEntity<String> delete(String groupId) {
 
         Group group = findSingleGroupByIdInCacheOrDatabase(groupId);