Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/using-bills-variable #16

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

fivetran-joemarkiewicz
Copy link
Collaborator

PR Overview

This PR will address the following Issue/Feature: Issue #15

This PR will result in the following new package version: v0.3.1

The addition of the variable to the tmp models should not be a breaking change.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

  • Included the sage_intacct__using_bills variable as an enablement config for the following models as it was erroneously omitted in previously releases:
    • stg_sage_intacct__ap_bill_item_tmp
    • stg_sage_intacct__ap_bill_tmp

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned.
  • All necessary documentation and version upgrades have been applied.
  • docs were regenerated (unless this PR does not include any code or yml updates).
  • BuildKite integration tests are passing.
  • Detailed validation steps have been provided below.

Detailed Validation

Please share any and all of your validation steps:

There was not much validation needed here. We can rely on the integration tests leveraging the variable to ensure this works as expected.

If you had to summarize this PR in an emoji, which would it be?

🧢

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review February 27, 2024 16:49
@fivetran-reneeli fivetran-reneeli linked an issue Feb 27, 2024 that may be closed by this pull request
4 tasks
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for release!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 05ae576 into main Feb 27, 2024
7 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the bugfix/using-bills-variable branch February 27, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] sage_intacct__using_bills is not applied to the tmp models
3 participants