-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gl batch addition #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran and tested locally, just one small change needed in the stg yml. Otherwise it all looks in order!
.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
PR Overview
This PR will address the following Issue/Feature: #13 and Issue #20 (dbt_sage_intacct)
This PR will result in the following new package version:
v0.3.0
This update is removing the
_fivetran_deleted
field from thegl_detail
staging models. While this field has been deprecated and is no longer synced via the connector. We should still mark this as breaking since this update could potentially cause failures for customers who are currently leveraging this field.Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🚨 Breaking Changes 🚨:
_fivetran_deleted
field from thestg_sage_intacct__gl_detail
table due to this field being deprecated within the connector. The relevant information is now available within thegl_batch
source table.Bug Fixes
class_id
field within the following models as{{ dbt.type_string() }}
in order to ensure datatype consistency for the field across models. This also ensures downstream transformation logic withindbt_sage_intacct
compiles successfully.stg_sage_intacct__ap_bill_item
stg_sage_intacct__ar_invoice_item
Feature Updates
gl_batch
source and relevant downstream models:stg_sage_intacct__gl_batch_tmp
stg_sage_intacct__gl_batch
Under the Hood
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
All validations were performed within the Sage Intacct Validations Hex workbook. Please refer to the Height ticket for a direct link to these validations. The Hex notebook includes the following validations:
gl_detail
modelgl_batch
modelsIf you had to summarize this PR in an emoji, which would it be?
🍡