Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gl batch addition #14

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Conversation

fivetran-joemarkiewicz
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Nov 30, 2023

PR Overview

This PR will address the following Issue/Feature: #13 and Issue #20 (dbt_sage_intacct)

This PR will result in the following new package version: v0.3.0

This update is removing the _fivetran_deleted field from the gl_detail staging models. While this field has been deprecated and is no longer synced via the connector. We should still mark this as breaking since this update could potentially cause failures for customers who are currently leveraging this field.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🚨 Breaking Changes 🚨:

  • Removal of the _fivetran_deleted field from the stg_sage_intacct__gl_detail table due to this field being deprecated within the connector. The relevant information is now available within the gl_batch source table.

Bug Fixes

  • Cast the class_id field within the following models as {{ dbt.type_string() }} in order to ensure datatype consistency for the field across models. This also ensures downstream transformation logic within dbt_sage_intacct compiles successfully.
    • stg_sage_intacct__ap_bill_item
    • stg_sage_intacct__ar_invoice_item

Feature Updates

  • Addition of the gl_batch source and relevant downstream models:
    • stg_sage_intacct__gl_batch_tmp
    • stg_sage_intacct__gl_batch

Under the Hood

  • Updated Maintainer PR Template
  • Included auto-releaser GitHub Actions workflow to automate future releases

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned.
  • All necessary documentation and version upgrades have been applied. Don't forget to update the version in the README if necessary.
  • docs were regenerated (unless this PR does not include any code or yml updates).
  • BuildKite integration tests are passing.
  • Detailed validation steps have been provided below.

Detailed Validation

Please share any and all of your validation steps:

All validations were performed within the Sage Intacct Validations Hex workbook. Please refer to the Height ticket for a direct link to these validations. The Hex notebook includes the following validations:

  • _fivetran_deleted proper removal from gl_detail model
  • Proper materialization of the gl_batch models

If you had to summarize this PR in an emoji, which would it be?

🍡

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review December 1, 2023 16:23
Copy link

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran and tested locally, just one small change needed in the stg yml. Otherwise it all looks in order!

models/stg_sage_intacct.yml Outdated Show resolved Hide resolved
models/stg_sage_intacct.yml Show resolved Hide resolved
Copy link

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 4d4b76e into main Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants