bugfix/timestamp-without-time-zone #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages.yml
Outdated
Comment on lines
2
to
6
| # version: [">=0.2.0", "<0.3.0"] | ||
| - git: https://github.com/fivetran/dbt_qualtrics_source.git | ||
| revision: bugfix/timestamp-without-time-zone | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Will swap before release
| @@ -1,4 +1,4 @@ | |||
|
|
|||
| env/ | |||
There was a problem hiding this comment.
Probably should add package-lock.yml for good measure.
There was a problem hiding this comment.
The package-lock.yml is already included in the .gitignore.
CHANGELOG.md
Outdated
| @@ -1,3 +1,11 @@ | |||
| # dbt_qualtrics v0.2.0 | |||
There was a problem hiding this comment.
Source Changelog has v.Number.Number in front of the package, transform has v.Number.Number behind it. I know the auto-releaser will usually take care of this but since it's broken, something to watch out for here if you're manually releasing.
There was a problem hiding this comment.
Good call, I just updated the ordering to be consistent with the source and our other packages.
fivetran-avinash
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Internally raised issue
This PR will result in the following new package version:
v0.2.0This will be breaking due to breaking changes in the upstream source package.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
First I recreated the issue by setting up a new Qualtrics connector (for Redshift) and attempted to use the production version of the package. Alas, I saw the same error as documented:
I then installed the local version of the qualtrics package with these changes included and saw the errors resolved!
If you had to summarize this PR in an emoji, which would it be?
🐻