[Feature] Standardized Marketing Models #146
Conversation
There was a problem hiding this comment.
@fivetran-avinash thanks for working through this PR. I didn't review the documentation since we'll likely update that before release.
However, I did review the standardized models and have a few initial comments. Let me know if you want to sync on these at all.
| {% set emails_enabled = fivetran_utils.enabled_vars(['hubspot_marketing_enabled', 'hubspot_email_event_enabled', 'hubspot_email_event_sent_enabled']) %} | ||
| {% set engagements_enabled = fivetran_utils.enabled_vars(['hubspot_sales_enabled', 'hubspot_engagement_enabled','hubspot_engagement_contact_enabled']) %} |
There was a problem hiding this comment.
Are these variables used at all?
There was a problem hiding this comment.
They are not. Removed.
| total_deferrals, | ||
| total_deliveries, | ||
| total_opens, | ||
| cast(null as {{ dbt.type_int() }}) as total_unsubscribes, |
There was a problem hiding this comment.
Is this not available? It looks like we should have the information to generate unsubscribes from the reference table.
There was a problem hiding this comment.
They were available, but took some rejiggering of the models to make this work. You can see the updated CHANGELOG for details (will add more in the Height ticket).
| total_drops, | ||
| total_forwards, | ||
| total_opens, | ||
| cast(null as {{ dbt.type_int() }}) as total_unsubscribes, |
There was a problem hiding this comment.
It looks like we should have this information in the underlying table. Is this not accessible?
There was a problem hiding this comment.
See the above comment.
| forwards as total_forwards, | ||
| opens as total_opens, | ||
| spam_reports as total_spam_reports, | ||
| cast(null as {{ dbt.type_int() }}) as total_unsubscribes, |
There was a problem hiding this comment.
Same comment about why these are not able to be used if it seems they are available in the underlying table.
There was a problem hiding this comment.
See the above comment.
| was_delivered, | ||
| was_forwarded, | ||
| was_opened, | ||
| cast(null as {{ dbt.type_boolean()}}) was_unsubscribed |
There was a problem hiding this comment.
Same as above comment. It looks like this should be available?
There was a problem hiding this comment.
See the above comment.
There was a problem hiding this comment.
@fivetran-joemarkiewicz This PR is ready for re-review, see Height for more thorough notes on changes made.
PR Overview
This PR will address the following Issue/Feature: Standardized Marketing Models project
This PR will result in the following new package version: v0.19.0
Not a breaking change but this feature update is significant enough to warrant a versioning bump.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates
*_marketing_campaigns_standardizedmodel found in Hubspot, Marketo, Iterable, Klaviyo, Mailchimp, Qualtrics, Salesforce Marketing Cloud, and Twilio. To see the kinds of insights this model can generate, explore example visualizations in the Fivetran Marketing Model Streamlit App. Visit the app for more details.*_marketing_contacts_standardizedmodel found in Hubspot, Marketo, Iterable, Klaviyo, Mailchimp, Qualtrics, Salesforce Marketing Cloud, and Twilio. To see the kinds of insights this model can generate, explore example visualizations in the Fivetran Marketing Model Streamlit App. Visit the app for more details.*_marketing_events_standardizedmodel found in Hubspot, Marketo, Iterable, Klaviyo, Mailchimp, Qualtrics, Salesforce Marketing Cloud, and Twilio. To see the kinds of insights this model can generate, explore example visualizations in the Fivetran Marketing Model Streamlit App. Visit the app for more details.*__line_item_enhancedmodel found in Hubspot, Marketo, Iterable, Klaviyo, Mailchimp, Qualtrics, Salesforce Marketing Cloud, and Twilio, offering standardized reporting across various marketing platforms. To see the kinds of insights this model can generate, explore example visualizations in the Fivetran Marketing Model Streamlit App. Visit the app for more details.hubspot__standardized_marketing_model_enabledastruein yourdbt_project.yml.Under the Hood:
integration_testsfor thehubspot__contacts,hubspot__email_campaignsandhubspot__email_sendsmodels.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Can confirm the new schema is being pulled through on a dbt run.
Validation tests were passing on both development.
As well as integration tests.
If you had to summarize this PR in an emoji, which would it be?
📧